Thanks, I would take a look when I'm home. I'd also try to see what https://github.com/astral-sh/ruff does in their parser to detect the "()" on the names. But I do think your other idea with checking the source code using offset worth giving a try too.

By the way for tests you can use https://insta.rs/docs/cli/ to update them.

CodSpeed Performance Report

Merging #245 will not alter performance

_{Comparing dwoznicki:simple-flag-annotated-assignment (398c573) with main (d6dc09e)}

Summary

✅ 4 untouched benchmarks

Okay, I added some tests. I can't help but feel like this is too much overhead for such a niche use case. Perhaps this should be a new expression type, ParenthesizedName? How closely are you trying to follow the standard Python AST node types?

Okay, I added some tests. I can't help but feel like this is too much overhead for such a niche use case. Perhaps this should be a new expression type, ParenthesizedName? How closely are you trying to follow the standard Python AST node types?

I think this extra field is better than a new node type. Since that new node type has to be handled in type checker when getting type for an expression and might complicate more stuff.

With current approach we can leave the detail inside the parser. I think we can even override fmt debug for the Name to hide this attribute in the debug value so it won't show up in the tests as a change.
https://doc.rust-lang.org/std/fmt/trait.Debug.html#examples

Cool, I like that idea. Tests should be good to go. Looks like codecov is getting (badly) throttled.

[2024-06-27T06:04:24.041Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 429 - {'detail': ErrorDetail(string='Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 2947s.', code='throttled')}